After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696135 - h264parse: Add mvc stream parsing support
h264parse: Add mvc stream parsing support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: Jan Schmidt
GStreamer Maintainers
Depends on: 685215
Blocks: 743174
 
 
Reported: 2013-03-19 12:58 UTC by sreerenj
Modified: 2015-01-20 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videoparsers: h264parse: Add MVC stream parsing support. (9.92 KB, patch)
2013-03-19 12:58 UTC, sreerenj
none Details | Review
h264parse: add initial support for MVC NAL units (3.99 KB, patch)
2014-06-25 13:22 UTC, Gwenole Beauchesne
committed Details | Review

Description sreerenj 2013-03-19 12:58:27 UTC
Created attachment 239246 [details] [review]
videoparsers: h264parse: Add MVC stream parsing support.

Hi,

This is to add h264 mvc stream parsing support to h264parse element based on the codecparser API provided in https://bugzilla.gnome.org/show_bug.cgi?id=685215.

Attaching the initial patch which handles the following parts,

*parse subset sequence parameter set
*taking care of slice_nal_extenion
*taking care of MVCDecoderConfigurationRecord.
*and other necessary stuffs

This is still missing the Stereo_Video_Info and Frame_Packing_Arrangement SEI payload parsing stuffs which has been added to codec_parser library (bug: 685215). This one will be added based on https://bugzilla.gnome.org/show_bug.cgi?id=611157 . As per the comment2 in bug:611157 from Stefan Saur,
"The caps would tell whether it is a multichannel videostream (channels={1,2})
and in case of 2 how the frames are
packed(channel-layout={mono,separate,stereo-interleaved,stereo-over-under,stereo-left-right})."

Expecting some comments.. ?
Comment 1 Gwenole Beauchesne 2013-05-31 12:31:08 UTC
Hi, the code for detecting AU boundaries needs to be updated too, I think. Only checking for first_mb_in_slice == 0 doesn't look correct in the general case, even for standard AVC cases (baseline profile with ASO, in particular).

This also reminds me to create a new entry for the demuxers and/or link it to here. The most important thing there would be to handle "stream-id" and "layer-id" (for SVC) properties. Otherwise, the current behaviour is that we generate as many decoder + sinks as there are substreams IIRC.
Comment 2 Gwenole Beauchesne 2014-06-25 13:22:31 UTC
Created attachment 279221 [details] [review]
h264parse: add initial support for MVC NAL units

Same patch as sree's but without the MVC configuration record from MP4 spec. Additional fixes for robustness and optimization purposes.
Comment 3 Víctor Manuel Jáquez Leal 2015-01-16 18:05:43 UTC
ping?

Any committer could review this patch? I think it is a good idea to have it to support multiview and stereo profiles in the future.
Comment 4 Tim-Philipp Müller 2015-01-16 18:21:44 UTC
Jan was working on integrating that.
Comment 5 Jan Schmidt 2015-01-20 13:31:18 UTC
Yes, I should have pushed this a while ago