After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 696022 - GOComboColor:color_changed signal marshalling is wrong
GOComboColor:color_changed signal marshalling is wrong
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Gtk+
GIT
Other All
: Normal major
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-03-18 01:48 UTC by Morten Welinder
Modified: 2013-03-20 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Morten Welinder 2013-03-18 01:48:45 UTC
The first argument to this signal is defined to be a gpointer, but
in reality we supply a GOColor (==guin32).

Compare...

	go_combo_color_signals [COLOR_CHANGED] =
		g_signal_new ("color_changed",
			      G_OBJECT_CLASS_TYPE (gobject_class),
			      G_SIGNAL_RUN_LAST,
			      G_STRUCT_OFFSET (GOComboColorClass, color_changed),
			      NULL, NULL,
			      go__VOID__INT_BOOLEAN_BOOLEAN_BOOLEAN,
			      G_TYPE_NONE, 4, G_TYPE_POINTER,
			      G_TYPE_BOOLEAN, G_TYPE_BOOLEAN, G_TYPE_BOOLEAN);

(which can't even agree with itself about that type) and

  	g_signal_emit (cc,
		       go_combo_color_signals [COLOR_CHANGED], 0,
		       color, is_custom, by_user, is_default);

There doesn't seem to be a G_TYPE_whatever that covers guin32.
Comment 1 Morten Welinder 2013-03-20 22:40:17 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.