After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695973 - fix build error with -Werror=format-security
fix build error with -Werror=format-security
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-03-16 17:48 UTC by Andreas Henriksson
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix build error with -Werror=format-security (3.41 KB, patch)
2013-03-16 17:48 UTC, Andreas Henriksson 		committed Details | Review

Description Andreas Henriksson 2013-03-16 17:48:33 UTC 
partial build output:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -pthread -I/usr/includ
e/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gio-unix-
2.0/ -I/usr/include/p11-kit-1 -DG_LOG_DOMAIN=\"Gcr\" -DGCR_API_SUBJECT_TO_CHANGE
 -DLOCALEDIR=\"/usr/share/locale\" -D_FORTIFY_SOURCE=2 -DGCK_API_SUBJECT_TO_CHAN
GE -DP11_KIT_API_SUBJECT_TO_CHANGE -DGCR_COMPILATION -pthread -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -DUIDIR=\"/usr/share/gcr-3/ui/\" -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -g -Wno-strict-aliasing -Wno-sign-compare -c gcr-certificate-exporter.c  -fPIC -DPIC -o .libs/libgcr_ui_3_la-gcr-certificate-exporter.o
gcr-certificate-exporter.c: In function 'on_create_file_ready':
gcr-certificate-exporter.c:230:8: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors
make[5]: *** [libgcr_ui_3_la-gcr-certificate-exporter.lo] Error 1
Comment 1 Andreas Henriksson 2013-03-16 17:48:36 UTC 
Created attachment 239031 [details] [review]
fix build error with -Werror=format-security
Comment 2 Stef Walter 2013-06-18 14:33:24 UTC 
Thanks for the patch. Pushed to git master.

Attachment 239031 [details] pushed as 1d7b974 - fix build error with -Werror=format-security