GNOME Bugzilla – Bug 695966
parent location struct leaked in EphySession
Last modified: 2016-01-20 09:54:36 UTC
==1512== 8 bytes in 1 blocks are definitely lost in loss record 646 of 11,860 ==1512== at 0x4A0887C: malloc (vg_replace_malloc.c:270) ==1512== by 0x7D8275E: g_malloc (gmem.c:159) ==1512== by 0x7D9B005: g_slice_alloc (gslice.c:1003) ==1512== by 0x451864: parent_location_new (ephy-session.c:145) ==1512== by 0x451A7B: closed_tab_new (ephy-session.c:217) ==1512== by 0x451F0F: ephy_session_tab_closed (ephy-session.c:372) ==1512== by 0x4520F9: notebook_page_removed_cb (ephy-session.c:424) ==1512== by 0x759A09A: _gtk_marshal_VOID__OBJECT_UINT (gtkmarshalers.c:5742) ==1512== by 0x7CE0BEC: g_closure_invoke (gclosure.c:777) ==1512== by 0x7CFE892: signal_emit_unlocked_R (gsignal.c:3584) ==1512== by 0x7CFDADA: g_signal_emit_valist (gsignal.c:3328) ==1512== by 0x7CFE022: g_signal_emit (gsignal.c:3384) ==1512== by 0x75CE47D: gtk_notebook_remove (gtknotebook.c:4151) ==1512== by 0x450AF4: ephy_notebook_remove (ephy-notebook.c:787) ==1512== by 0x7CE58F4: g_cclosure_marshal_VOID__OBJECTv (gmarshal.c:1312) ==1512== by 0x7CE12C1: g_type_class_meta_marshalv (gclosure.c:997) ==1512== by 0x7CE0E84: _g_closure_invoke_va (gclosure.c:840) ==1512== by 0x7CFCE40: g_signal_emit_valist (gsignal.c:3234) ==1512== by 0x7CFE022: g_signal_emit (gsignal.c:3384) ==1512== by 0x74B29AE: gtk_container_remove (gtkcontainer.c:1546)
Created attachment 319257 [details] [review] ephy-session: stop saving the back forward list for recently closed tabs
Created attachment 319258 [details] [review] ephy-session: simplify the code to track closed tabs parent notebook
Review of attachment 319257 [details] [review]: Can you please also filter out tabs where the URI is just "http://"? Sometimes when ephy crashes in just the wrong place -- not sure where -- the session gets corrupted and all the URIs load as http://
Review of attachment 319258 [details] [review]: I hope there's a simpler way to handle this....
Patches pushed to git master