After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695897 - Compilation errors on srtp
Compilation errors on srtp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-15 08:32 UTC by Jose Antonio Santos Cadenas
Modified: 2013-03-15 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix compilation error (787 bytes, patch)
2013-03-15 08:32 UTC, Jose Antonio Santos Cadenas 		committed Details | Review
Fix compilation warning (778 bytes, patch)
2013-03-15 08:33 UTC, Jose Antonio Santos Cadenas 		committed Details | Review

Description Jose Antonio Santos Cadenas 2013-03-15 08:32:44 UTC 
Created attachment 238962 [details] [review]
Fix compilation error

New srtp module does not compile due to missing value. I attach patches that solve this issue and other compilation warning.
Comment 1 Jose Antonio Santos Cadenas 2013-03-15 08:33:22 UTC 
Created attachment 238963 [details] [review]
Fix compilation warning
Comment 2 Tim-Philipp Müller 2013-03-15 11:07:03 UTC 
Pushed, thanks:

commit ea2332c46626273b2c2fe36e1dee8e4eff2add48
Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Date:   Fri Mar 15 09:29:42 2013 +0100

    srtp: fix compilation warning returning NULL in case of error
    
    https://bugzilla.gnome.org/show_bug.cgi?id=695897

commit 2347c4e711d8b8630fc2654b6910c69adf94f164
Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Date:   Fri Mar 15 09:27:36 2013 +0100

    srtp: use constant AES_128_ICM instead of AES_ICM that is not found
    
    https://bugzilla.gnome.org/show_bug.cgi?id=695897


Compiled fine with my version of libsrtp (1.4.4+20100615~dfsg-2) though.