GNOME Bugzilla – Bug 695885
Add a way to filter accounts and provider by feature provided
Last modified: 2018-04-17 09:35:55 UTC
When editing accounts from a specific program it may be useful to avoid showing the ones not related to the application: eg. when invoked from Empathy, Online Accounts should show only the accounts and providers that are able to provide an instant messaging service.
Created attachment 238939 [details] [review] online-accounts: Filter accounts and providers by provided feature This adds a 'show' sub-sub-command to the online-accounts panel, accepting the name of the feature for which to filter. To only see accounts and providers with mail capabilities launch g-c-c like this: $ gnome-control-center online-accounts show mail *** NOTE *** this patch depends on the GVariant-based parameters passing rework from bug #694315: https://bugzilla.gnome.org/attachment.cgi?id=237722
Created attachment 238943 [details] [review] online-accounts: Filter accounts and providers by provided feature This adds a 'show' sub-sub-command to the online-accounts panel, accepting the name of the feature for which to filter. To only see accounts and providers with mail capabilities launch g-c-c like this: $ gnome-control-center online-accounts show mail
Created attachment 238977 [details] [review] online-accounts: Move from _provider_group() to _provider_features() With the attachment https://bugzilla.gnome.org/attachment.cgi?id=238975 to bug #695886 goa_provider_get_provider_group() has been deprecated in favour of goa_provider_get_provider_features() which returns a bitmask of flags instead of an enum.
Created attachment 239123 [details] [review] online-accounts: Move from _provider_group() to _provider_features() goa_provider_get_provider_group() has been deprecated in favour of goa_provider_get_provider_features() which returns a bitmask of flags instead of an enum.
Created attachment 239124 [details] [review] online-accounts: Filter accounts and providers by provided feature This adds a '--feature' command line flag to the online-accounts panel, accepting the name of the feature for which to filter. To only see accounts and providers with mail capabilities launch g-c-c like this: $ gnome-control-center online-accounts --feature mail Rebased on top of current master+bug #696054 to be able to use the --feature flag.
Review of attachment 239123 [details] [review]: Looks good to me. Bastien?
What if someone jumps from Empathy to GOA, with the intention of doing something not related to Empathy? People use this type of workaround all the time.
(In reply to comment #7) > What if someone jumps from Empathy to GOA, with the intention of doing > something not related to Empathy? People use this type of workaround all the > time. Exactly my problem with this feature. A good way to work-around that problem might be to have another way to present the different accounts, by type instead of by provider, and simply focus the chat type when you come from empathy. But that would require quite a few changes in the UI.
Allan, could you please mock-up a UI for GOA that would satisfy Bastien's description in comment #8? I think I see what he's saying but I'm not sure the best way to lay it out.
A possible solution would be to have an info bar that says something like “Diplaying only chat accounts” with a button “Show everything” when the control centre is opened from empathy. Maybe it's not pretty, but I'm not a designer :) Anyway, I think we would need something that, from a practical point of view, is similar to this.
Review of attachment 239123 [details] [review]: ::: panels/online-accounts/cc-online-accounts-add-account-dialog.c @@ +421,3 @@ + { + g_warning ("Unable to classify provider '%s'", goa_provider_get_provider_type (provider)); + return; I prefer the g_assert_not_reached, because this shouldn't happen unless you are running mismatched GOA and g-c-c versions. See my comment in bug 706148 about this.
Review of attachment 239124 [details] [review]: Looks good to me, assuming that the designers are happy with it.
Comment on attachment 239124 [details] [review] online-accounts: Filter accounts and providers by provided feature Marking as needs-work as it doesn't match the UI requested, and it doesn't apply cleanly any more.
Sadly, this bug has been obsoleted by the fact that the Empathy / Telepathy stack has been abandoned in GNOME. As a result, the Telepathy provider is being dropped from gnome-online-accounts (bug 795322). Moreover, the original intention behind this bug was that Empathy would eventually drop its own account management UI and just rely on Settings -> Online Accounts. That hasn't happened, and it won't be prudent to do so given that Empathy and Telepathy are no longer core components of GNOME.
Review of attachment 239123 [details] [review]: :(
Review of attachment 239124 [details] [review]: :(