After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695881 - background-group: Subclass ClutterActor, not ClutterGroup
background-group: Subclass ClutterActor, not ClutterGroup
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-14 21:26 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-03-14 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background-group: Subclass ClutterActor, not ClutterGroup (1.88 KB, patch)
2013-03-14 21:26 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-03-14 21:26:15 UTC 
We use the new Clutter Actor API in the shell, so we really
shouldn't be using ClutterGroup.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-03-14 21:26:17 UTC 
Created attachment 238928 [details] [review]
background-group: Subclass ClutterActor, not ClutterGroup
Comment 2 Ray Strode [halfline] 2013-03-14 21:28:12 UTC 
Review of attachment 238928 [details] [review]:

++

::: src/meta/meta-background-group.h
@@ +12,1 @@
  * MetaBackgroundActor when painting the group. It makes sure to only

s/MetaBackgroundActor when painting the group/painting MetaBackgroundActor children/ (or something)
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-14 21:49:16 UTC 
Attachment 238928 [details] pushed as 0bb8d29 - background-group: Subclass ClutterActor, not ClutterGroup


I chose not to change the wording as MetaWindowGroup has the same
issue -- perhaps we should change it in the future, as it also says
that it's a subclass of ClutterGroup.