After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695859 - Another child popup menu regression
Another child popup menu regression
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.8.1
: 696423 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-14 15:53 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-03-27 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popupMenu: Fix a missed rename (837 bytes, patch)
2013-03-14 15:53 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Fix another child popup regression (877 bytes, patch)
2013-03-14 15:53 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
popupMenu: Fix another child popup regression (929 bytes, patch)
2013-03-14 16:02 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
popupMenu: Fix another child popup regression (986 bytes, patch)
2013-03-14 16:03 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-03-14 15:53:14 UTC 
Open the nested combobox, then mouse over another panel item.

Not 100% happy with the patch; I'll probably clean this up after 3.8.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-03-14 15:53:16 UTC 
Created attachment 238887 [details] [review]
popupMenu: Fix a missed rename

this._activeMenu was changed to this.activeMenu, but this wasn't
updated by accident.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-03-14 15:53:20 UTC 
Created attachment 238888 [details] [review]
popupMenu: Fix another child popup regression

When switching menus, we need to make sure we close all existing
grabs, not just the first one.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-14 16:02:20 UTC 
Created attachment 238892 [details] [review]
popupMenu: Fix another child popup regression

When switching menus, we need to make sure we close all existing
grabs, not just the first one.



Fix an exception when menus were destroyed without an active grab.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-03-14 16:03:06 UTC 
Created attachment 238893 [details] [review]
popupMenu: Fix another child popup regression

When switching menus, we need to make sure we close all existing
grabs, not just the first one.
Comment 5 Giovanni Campagna 2013-03-14 17:41:47 UTC 
Review of attachment 238887 [details] [review]:

Ok.
Comment 6 Giovanni Campagna 2013-03-14 17:42:33 UTC 
Review of attachment 238893 [details] [review]:

LGTM
Comment 7 Matthias Clasen 2013-03-20 09:46:29 UTC 
Will somebody ask for a freeze break ?
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-03-22 20:37:38 UTC 
*** Bug 696423 has been marked as a duplicate of this bug. ***
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-03-27 13:50:04 UTC 
This didn't go in 3.8. I don't think it's too serious, and it takes a bit of playing around to hit, so I'm comfortable with this going in 3.8.1.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-03-27 20:33:21 UTC 
Attachment 238887 [details] pushed as e6469df - popupMenu: Fix a missed rename
Attachment 238893 [details] pushed as 6fd5f0e - popupMenu: Fix another child popup regression