Created attachment 238866 [details] [review]
status/keyboard: Always hide the old source panel indicator label

When we switch into an invalid input source we hide the panel
indicator and return early but we were not hiding the previously
active source label and its menu item dot and thus when switching
again to a third input source we would end up showing 2 overlapping
labels in the panel and the menu would have 2 entries with a dot.

Created attachment 238867 [details] [review]
status/keyboard: Check if this._currentSource is valid on activation

this._currentSource might be invalid so check for that to prevent an
exception and still switch to the newly activated source.

Review of attachment 238866 [details] [review]:

OK.

Review of attachment 238867 [details] [review]:

I'm not sure why this._currentSource would be invalid, but OK.

(In reply to comment #4)
> I'm not sure why this._currentSource would be invalid, but OK.

That's happens if the gsetting has "garbage" or, more likely an ibus
engine id for an engine that for some reason doesn't work anymore,
like it could have been uninstalled or has some bug and crashes or
so.


Attachment 238866 [details] pushed as 5c89568 - status/keyboard: Always hide the old source panel indicator label
Attachment 238867 [details] pushed as 01deb9e - status/keyboard: Check if this._currentSource is valid on activation

Thank you, that works.