After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695760 - search provider icon alignment is off vertically
search provider icon alignment is off vertically
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-13 11:52 UTC by Jakub Steiner
Modified: 2013-08-15 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shows the actual provider icon misalignment (339.17 KB, image/png)
2013-03-13 11:52 UTC, Jakub Steiner 		  Details
Adds padding to search provider icon (1.04 KB, patch)
2013-06-26 13:13 UTC, Tarun Joshi 		committed Details | Review
screenshot (951.18 KB, image/png)
2013-06-27 11:33 UTC, Allan Day 		  Details

Description Jakub Steiner 2013-03-13 11:52:33 UTC 
Created attachment 238770 [details]
shows the actual provider icon misalignment

The provider icon, while smaller than the result icons, should align to the top of the results block. 

See https://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/search-results-layout.png or the attached guideline.
Comment 1 Jakub Steiner 2013-06-20 13:22:08 UTC 
The problem seems to be the different padding in the tiles. The rectangles themselves do align (when checking with hover).
Comment 2 Tarun Joshi 2013-06-26 13:13:20 UTC 
Created attachment 247821 [details] [review]
Adds padding to search provider icon

This adds 15px padding to the provider icon so that padding in the tiles are same. It makes the rectangular box which appears on hover behind provider icon big as a side effect.
Comment 3 Allan Day 2013-06-27 11:33:34 UTC 
Created attachment 247894 [details]
screenshot

Looks good to me!
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-15 12:14:42 UTC 
Review of attachment 247821 [details] [review]:

OK.
Comment 5 drago01 2013-08-15 12:25:49 UTC 
Just pushed it.