GNOME Bugzilla – Bug 695747
tooltip showing when screen locked
Last modified: 2013-03-18 07:58:00 UTC
Created attachment 238758 [details] screenshot I resumed my laptop and noticed that there was a tooltip over the lockscreen.
Created attachment 238761 [details] [review] screenShield: Hide window groups while locked We don't want to show any windows, nor tooltips while the lockscreen is active.
Created attachment 238762 [details] [review] screenShield: Hide window groups while locked We don't want to show any windows, nor tooltips while the lockscreen is active.
Technically wrong for the gdm screen shield, since we should re-show the window groups. Fun :)
(In reply to comment #3) > Technically wrong for the gdm screen shield, since we should re-show the window > groups. Fun :) Wait what? Why do we have lockscreen for gdm? That makes zero sense ...
I don't know, but the screen shield exists for the greeter.
Created attachment 238763 [details] [review] screenshield: Don't lock in gdm This makes no sense at all. There is nothing to hide we already have a password dialog up. --- Untested but seriously why do we do that?!
Ugh the lookscreen on the greeter also does not focus the entry after lifting the screen. One more reason to kill it as it is nonsensical anyway.
(In reply to comment #6) > This makes no sense at all. There is nothing to hide we already have a password > dialog up. By the same reasoning, the lock screen shouldn't use the screen shield either and just display the unlock dialog. (Also note that screen shield != lock - even inside a session the shield may be shown without the screen being locked)
(In reply to comment #8) > (In reply to comment #6) > > This makes no sense at all. There is nothing to hide we already have a password > > dialog up. > > By the same reasoning, the lock screen shouldn't use the screen shield either > and just display the unlock dialog. No because there are more things we can show if we have a running session (like notifications etc). If the greeter is open for a long enough time for the look to kick in all we should do is to turn off the display. I simply don't see a point of the shield at gdm.
Created attachment 238768 [details] [review] screenShield: Hide window groups while locked We don't want to show any windows, nor tooltips while the lockscreen is active. --- Seems like screenshield at gdm was intenional and removing it is not as easy (i.e no discussion) as I initially assumed so lets just do this by wrapping the window_group.show() calls inside a if(!this._isGreeter) ...
(In reply to comment #9) > No because there are more things we can show if we have a running session (like > notifications etc). We do display notifications in the screen shield (if desired), but showing notifications while the session is locked does not require a shield - they could just as well be shown in the unlock dialog. > I simply don't see a point of the shield at gdm. I guess the main incentive is consistency with the lock screen. In any case, if you want to pursue this, this patch requires both designer approval and a UI freeze exception (it's a user-visible change wrt the last stable release, so not something we should sneak in)
(In reply to comment #10) > Seems like screenshield at gdm was intenional Yes, it's designed behavior.
Ahem... Can I ask what has the gdm greeter to do with window groups at all (there are no windows in gdm)? Window groups should be hidden while the shield is active, locked or not. Arguably, this would be a session mode property.
(In reply to comment #13) > Ahem... Can I ask what has the gdm greeter to do with window groups at all > (there are no windows in gdm)? > Window groups should be hidden while the shield is active, locked or not. We hide the window groups in layout.js when we're in greeter mode, so we probably shouldn't show it when raising the shield either. > Arguably, this would be a session mode property. The property is allowWindows. For some reason we don't use that to hide the window_group/top_window_group in layout.js either. (This is why I was not a big fan of isGreeter landing -- we were going to use it all over the place for random unrelated stuff like this.)
(In reply to comment #14) > (In reply to comment #13) > > Ahem... Can I ask what has the gdm greeter to do with window groups at all > > (there are no windows in gdm)? > > Window groups should be hidden while the shield is active, locked or not. > > We hide the window groups in layout.js when we're in greeter mode, so we > probably shouldn't show it when raising the shield either. Oh, I see what you mean. But then, can't layout.js handle it for the unlock case too? > > Arguably, this would be a session mode property. > > The property is allowWindows. For some reason we don't use that to hide the > window_group/top_window_group in layout.js either. > > (This is why I was not a big fan of isGreeter landing -- we were going to use > it all over the place for random unrelated stuff like this.) _isGreeter inside ScreenShield means one thing and one only: don't destroy the dialog when done. SessionMode.isGreeter is also used for startup animation (in main and layout), but I think that's ok too - what else would it be, hasGreeterAnimation?
Created attachment 238812 [details] [review] layout: Move window_group visibility to the layout This ensures that windows are hidden in the screen shield and in gdm. Here's a patch I like better.
Hard code freeze ping.
Review of attachment 238812 [details] [review]: Ah, I thought I had reviewed this. Looks good.
Attachment 238812 [details] pushed as b328fd7 - layout: Move window_group visibility to the layout