After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695692 - "Start using GNOME 3" button should use the distro name
"Start using GNOME 3" button should use the distro name
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
3.10
Depends on:
Blocks:
 
 
Reported: 2013-03-12 10:47 UTC by Allan Day
Modified: 2013-08-13 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the distro name in the 'Start' button (2.73 KB, patch)
2013-08-13 17:05 UTC, Matthias Clasen 		committed Details | Review

Description Allan Day 2013-03-12 10:47:43 UTC 
If someone just booted into their new distro, it will seem a little strange to be greeted by a button reading "Start using GNOME 3". My suggestion would be to replace the "GNOME 3" with the distro name: "Start using Fedora", "Start using Ubuntu", "Start using OpenSUSE", etc.
Comment 1 Matthias Clasen 2013-03-12 21:37:35 UTC 
I agree, it was always my plan to make that string replaceable.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-06-16 04:25:32 UTC 
I can try to automatically parse the distro name from /etc/os-release or similar.
Comment 3 Matthias Clasen 2013-08-13 17:05:46 UTC 
Created attachment 251527 [details] [review]
Use the distro name in the 'Start' button

Parse /etc/os-release to find the name of the distribution, and
use it instead of 'GNOME 3'. If we don't find that file, fall back
to using 'GNOME 3'.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-13 17:21:10 UTC 
Review of attachment 251527 [details] [review]:

Technically we need to parse escapes and things like that, but it seems other tools blindly look for the quotes too (systemd-analyze), and I doubt we'll ever see escaped quotes in /etc/os-release (until we have NAME="Fedora 24 (Beefy \"Really Beefy\" Miracle)" ofc.), so OK.
Comment 5 Matthias Clasen 2013-08-13 17:33:03 UTC 
The parsing code was copied from a control-center patch we ship in Fedora
Comment 6 Matthias Clasen 2013-08-13 17:33:58 UTC 
Attachment 251527 [details] pushed as dfc86a4 - Use the distro name in the 'Start' button