After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695582 - Workspace: don't place new windows at random locations
Workspace: don't place new windows at random locations
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-10 18:43 UTC by Giovanni Campagna
Modified: 2013-03-17 18:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Workspace: don't place new windows at random locations (2.61 KB, patch)
2013-03-10 18:43 UTC, Giovanni Campagna 		reviewed Details | Review
Workspace: don't place new windows at random locations (3.75 KB, patch)
2013-03-17 18:30 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-03-10 18:43:29 UTC 
Instead, have them grow from the center of their assigned slots.
Comment 1 Giovanni Campagna 2013-03-10 18:43:32 UTC 
Created attachment 238537 [details] [review]
Workspace: don't place new windows at random locations
Comment 2 Giovanni Campagna 2013-03-16 22:40:08 UTC 
Hard code freeze ping!
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-17 17:39:31 UTC 
Review of attachment 238537 [details] [review]:

::: js/ui/workspace.js
@@ +1042,3 @@
+                // This window appeared after the overview was already up
+                // Grow the clone from the center of the slot
+                clone.actor.x = clone.slot[0] + clone.slot[2]/2;

let [x, y, width, height] = clone.slot;

@@ +1399,3 @@
         let overlay = new WindowOverlay(clone, this._windowOverlaysGroup);
         clone.overlay = overlay;
+        clone.positioned = true; // Will be cleared in _windowAdded for new windows

I'd like this to be passed into addWindowClone. Given that we only have two users that call it, it should be a match.
Comment 4 Giovanni Campagna 2013-03-17 18:30:47 UTC 
Created attachment 239068 [details] [review]
Workspace: don't place new windows at random locations

Instead, have them grow from the center of their assigned slots.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-03-17 18:32:09 UTC 
Review of attachment 239068 [details] [review]:

OK.
Comment 6 Giovanni Campagna 2013-03-17 18:36:07 UTC 
Attachment 239068 [details] pushed as 0ceefb4 - Workspace: don't place new windows at random locations