After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695540 - riff: support raw avi with negative height
riff: support raw avi with negative height
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-10 08:49 UTC by Dirk Van Haerenborgh
Modified: 2013-03-11 23:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
no negative height in caps (1.03 KB, patch)
2013-03-10 08:55 UTC, Dirk Van Haerenborgh 		committed Details | Review

Description Dirk Van Haerenborgh 2013-03-10 08:49:09 UTC 
Raw RGB is usually stored topdown, yet some tools (like ffmpeg) sometimes invert the height field instead. 
An example video, created with ffmpeg, can be found here: http://telin.ugent.be/~dvhaeren/clip.avi

This patch sets the caps to always have a positive height value. The height is not required to be positive in the strf data, since avidemux still needs to check if it really needs to invert the buffer.
Comment 1 Dirk Van Haerenborgh 2013-03-10 08:55:39 UTC 
Created attachment 238505 [details] [review]
no negative height in caps
Comment 2 Sebastian Dröge (slomo) 2013-03-11 13:24:21 UTC 
commit e8ca0528a9b2c9c255b25b9d822f97f24bf24879
Author: Dirk Van Haerenborgh <vhdirk@gmail.com>
Date:   Sun Mar 10 09:07:17 2013 +0100

    riff: never create caps with negative height
    
    https://bugzilla.gnome.org/show_bug.cgi?id=695540