After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695473 - treeview: fix a critical warning
treeview: fix a critical warning
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other All
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-08 23:29 UTC by Cosimo Cecchi
Modified: 2013-03-09 01:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
treeview: fix a critical warning (1.62 KB, patch)
2013-03-08 23:29 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-03-08 23:29:40 UTC 
See patch - this is a 3.7 regression caused by the switch to gtk_widget_register/unregister_window().
Comment 1 Cosimo Cecchi 2013-03-08 23:29:42 UTC 
Created attachment 238436 [details] [review]
treeview: fix a critical warning

gtk_tree_view_column_unset_tree_view() resets column->priv->tree_view to
NULL.
The function is called when a column is removed, but later from the same
function we would call _gtk_tree_view_column_unrealize_button(), which
expects column->priv->tree_view to be != NULL, causing these critical
warnings

Gtk-CRITICAL **: gtk_widget_unregister_window: assertion
`GTK_IS_WIDGET (widget)' failed

This commit moves the call to unset the tree view after the button is
unrealized.
Comment 2 Matthias Clasen 2013-03-09 01:19:53 UTC 
Attachment 238436 [details] pushed as fd51c8f - treeview: fix a critical warning