After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695409 - Small OSD window fixes
Small OSD window fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-07 21:52 UTC by Cosimo Cecchi
Modified: 2013-03-07 22:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
osdWindow: bump down the OSD window size a bit (1.25 KB, patch)
2013-03-07 21:52 UTC, Cosimo Cecchi 		committed Details | Review
osdWindow: change colors to match previous g-s-d style (1.22 KB, patch)
2013-03-07 21:52 UTC, Cosimo Cecchi 		rejected Details | Review

Description Cosimo Cecchi 2013-03-07 21:52:35 UTC 
The new shell OSD window doesn't exactly match what g-s-d used to do in some tiny details.
These patches fix it.
Comment 1 Cosimo Cecchi 2013-03-07 21:52:37 UTC 
Created attachment 238344 [details] [review]
osdWindow: bump down the OSD window size a bit

Matches what this commit did for g-s-d:
https://git.gnome.org/browse/gnome-settings-daemon/commit/plugins/media-keys?id=fbf3c5aa366ef7212f209e123d4aae315a1a2a8e
Comment 2 Cosimo Cecchi 2013-03-07 21:52:42 UTC 
Created attachment 238345 [details] [review]
osdWindow: change colors to match previous g-s-d style

The background of the OSD window was not exactly black, as it's too
prominent that way.
This commit makes it use the same colors it previously had when g-s-d
used to draw it.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-03-07 21:54:12 UTC 
Review of attachment 238344 [details] [review]:

OK.
Comment 4 Florian Müllner 2013-03-07 21:56:14 UTC 
Bastien mentioned that he tried to imitate the style used in the shell's switcher popups, so I changed the patch to not use the original OSD colors.
Comment 5 Cosimo Cecchi 2013-03-07 22:02:13 UTC 
(In reply to comment #4)
> Bastien mentioned that he tried to imitate the style used in the shell's
> switcher popups, so I changed the patch to not use the original OSD colors.

Ah okay, I didn't know that was intentional.
Comment 6 Cosimo Cecchi 2013-03-07 22:03:09 UTC 
Attachment 238344 [details] pushed as ce5faba - osdWindow: bump down the OSD window size a bit