After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695392 - window-list: Fill max-width if possible
window-list: Fill max-width if possible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-07 19:42 UTC by Florian Müllner
Modified: 2013-04-16 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window-list: Fill max-width if possible (4.05 KB, patch)
2013-03-07 19:42 UTC, Florian Müllner
reviewed Details | Review
window-list: Fill max-width if possible (958 bytes, patch)
2013-04-16 16:02 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2013-03-07 19:42:56 UTC
See patch. This prevents ugly size change of window list items and has bothered me for a while.
Comment 1 Florian Müllner 2013-03-07 19:42:59 UTC
Created attachment 238337 [details] [review]
window-list: Fill max-width if possible

Items in the window list should take up a fixed amount of space
unless the list is full and items need to shrink. To achieve this,
we set a max-width for items, but this only works if at least one
item has a title long enough to request a natural width larger than
that. To actually get the behavior we want, add a custom container
to the hierarchy which always uses the max-width in size requests.
Comment 2 Giovanni Campagna 2013-03-07 21:54:26 UTC
Review of attachment 238337 [details] [review]:

Sounds like -st-natural-width from bug 664411. I much rather get that in core shell, than adding this hack here.
Comment 3 Florian Müllner 2013-04-16 16:02:34 UTC
Created attachment 241658 [details] [review]
window-list: Fill max-width if possible

Items in the window list should take up a fixed amount of space
unless the list is full and items need to shrink. To achieve this,
replace the max-width with the newly added -st-natural-width.
Comment 4 Giovanni Campagna 2013-04-16 16:35:51 UTC
Review of attachment 241658 [details] [review]:

Looks good!
Comment 5 Florian Müllner 2013-04-16 16:47:57 UTC
Attachment 241658 [details] pushed as 702cf52 - window-list: Fill max-width if possible