GNOME Bugzilla – Bug 695358
Test suite fails if libphonenumber is not installed
Last modified: 2013-09-14 16:56:13 UTC
================================================================= evolution-data-server 3.7.92: tests/libebook/test-suite.log ================================================================= # TOTAL: 12 # PASS: 11 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: test-ebook-phone-number ============================= [snip] /ebook-phone-number/country-code/for-region: (/home/test/src/gnome/evolution-data-server/tests/libebook/.libs/lt-test-ebook-phone-number:19198): libebook-contacts-WARNING **: e_phone_number_get_country_code_for_region: The library was built without phone number support. This issue is fixed and verified in openismus-work-error-args branch
Created attachment 238292 [details] [review] proposed patch
Review of attachment 238292 [details] [review]: Basically no objection, just wait for a release-team approval (that's why accepted-commit_after_freeze). Will you bump a soname version for this change? Strictly speaking you should, but as it's a new API, used only internally now, I think it should work even without it. ::: tests/libebook/test-ebook-phone-number.c @@ +369,3 @@ + g_assert (error != NULL); + g_assert (error->domain == E_PHONE_NUMBER_ERROR); + g_assert (error->code == E_PHONE_NUMBER_ERROR_NOT_IMPLEMENTED); consider g_error_matches() as a replacement for the above three lines @@ +394,3 @@ + g_assert (error != NULL); + g_assert (error->domain == E_PHONE_NUMBER_ERROR); + g_assert (error->code == E_PHONE_NUMBER_ERROR_NOT_IMPLEMENTED); similar here
milan: did the separate steps so that the asserts directly tell me the issue, without the need of adding printf-statements during debugging. still now that i look it them, the domain and code checks rather should be g_assert_cmpint() checks. added similar checks at other places. will update them in one go after merging this one.
Comment on attachment 238292 [details] [review] proposed patch Got freeze break approval, merging to master. https://mail.gnome.org/archives/release-team/2013-March/msg00063.html https://mail.gnome.org/archives/release-team/2013-March/msg00064.html
Marking resolved and also deleting the openismus-work-error-args branch. Thank you for raising this issue.