After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695307 - Implement adblocker with WebKit2
Implement adblocker with WebKit2
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2013-03-06 17:09 UTC by Carlos Garcia Campos
Modified: 2013-03-06 19:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not build adblocker in ephy for wk2 (4.91 KB, patch)
2013-03-06 17:32 UTC, Carlos Garcia Campos 		committed Details | Review
Patch (4.21 KB, patch)
2013-03-06 17:32 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2013-03-06 17:09:43 UTC 
We need to use the new WebKitWebPage::send-request signal from the web extension
Comment 1 Carlos Garcia Campos 2013-03-06 17:32:06 UTC 
Created attachment 238217 [details] [review]
Do not build adblocker in ephy for wk2
Comment 2 Carlos Garcia Campos 2013-03-06 17:32:22 UTC 
Created attachment 238218 [details] [review]
Patch
Comment 3 Xan Lopez 2013-03-06 17:59:32 UTC 
Review of attachment 238217 [details] [review]:

This one looks good.
Comment 4 Xan Lopez 2013-03-06 18:02:20 UTC 
Review of attachment 238218 [details] [review]:

Also looks good to me.