After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695233 - Strings require plural forms
Strings require plural forms
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-03-05 17:50 UTC by Ján Kyselica
Modified: 2013-05-24 01:50 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
Patch: add missing gettext calls to gunixconnection.c (2.08 KB, patch)
2013-04-01 02:30 UTC, ElizabethHenry 		accepted-commit_now Details | Review

Description Ján Kyselica 2013-03-05 17:50:16 UTC 
Please use plural forms for these strings:

#: ../gio/gunixconnection.c:159 ../gio/gunixconnection.c:548
#, c-format
msgid "Expecting 1 control message, got %d"
msgstr ""

#: ../gio/gunixconnection.c:190
#, c-format
msgid "Expecting one fd, but got %d\n"
msgstr ""

https://live.gnome.org/TranslationProject/DevGuidelines/Plurals
Comment 1 ElizabethHenry 2013-04-01 02:30:14 UTC 
Created attachment 240275 [details] [review]
Patch: add missing gettext calls to gunixconnection.c
Comment 2 ElizabethHenry 2013-04-01 02:35:55 UTC 
Hi,

Here's an attempt at solving this bug. It seems to generate a correct .pot file, but given I'm not used to sending patches and bugzilla I'll just hope I did nothing wrong ^ ^
Comment 3 Atul Vinayak 2013-04-12 10:52:16 UTC 
how was it made plural?
Comment 5 ElizabethHenry 2013-04-12 11:34:26 UTC 
(In reply to comment #3)
> how was it made plural?

I'm not sure I understand the question, but in my attempt at a patch I used ngettext with the same form for singular or plural, as they are identical in english but not in some other languages (e.g. in french the translation of "got %d" might be "1 reçu" or "n reçus").  The manpage and the guidelines don't cover this particular case (where singular and plural are identical in english), but even if that means some redundancy it seemed as the more sensible thing to do.
Comment 6 Matthias Clasen 2013-04-13 15:49:22 UTC 
Review of attachment 240275 [details] [review]:

Looks right to me