After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695191 - Commit f641699 broke /appinfo/mime/api test case
Commit f641699 broke /appinfo/mime/api test case
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.35.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 695239 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-03-05 09:11 UTC by Martin Pitt
Modified: 2013-03-12 06:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix /appinfo/mime tests (3.34 KB, patch)
2013-03-11 08:39 UTC, Martin Pitt 		committed Details | Review

Description Martin Pitt 2013-03-05 09:11:21 UTC 
The recent commit http://git.gnome.org/browse/glib/commit/?id=f641699 for bug 675333 broke the gio/tests/mimeapps tests:

TEST: mimeapps... (pid=77385)
  /appinfo/mime/api:                                                   
(/home/ubuntu/gnome/checkout/glib/gio/tests/.libs/lt-mimeapps:77385): GLib-GIO-CRITICAL **: g_app_info_add_supports_type: assertion `G_IS_APP_INFO (appinfo)' failed

Full log: http://10.98.0.1:8080/view/Raring/view/JHBuild%20Gnome/job/jhbuild-amd64-glib/159/artifact/glib.log

Presumably because the test desktop files use Exec= lines like "my app" which don't actually exist. I figure the tests should be updated to use "Exec=sleep 1" and other commands which are guaranteed to be available, and perhaps one test case which actually exercises the new commit to reject .desktop files with a nonexisting Exec=?
Comment 1 Matthias Clasen 2013-03-06 19:26:40 UTC 
sounds good to me (using 'sleep 1') - could you come up with a patch for that ?
Comment 2 Matthias Clasen 2013-03-06 19:29:45 UTC 
*** Bug 695239 has been marked as a duplicate of this bug. ***
Comment 3 Martin Pitt 2013-03-11 08:39:23 UTC 
Created attachment 238564 [details] [review]
Fix /appinfo/mime tests

How about this? I verified that the new test case fails without commit f641699, and all tests succeed again now.
Comment 4 Matthias Clasen 2013-03-11 21:40:23 UTC 
Review of attachment 238564 [details] [review]:

Looks ok, thanks