After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695117 - Almanah doesn't encrypt the database when the application close
Almanah doesn't encrypt the database when the application close
Status: RESOLVED FIXED
Product: almanah
Classification: Other
Component: Encryption
0.9.x
Other Linux
: Normal blocker
: ---
Assigned To: diary-maint
diary-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-04 12:04 UTC by Álvaro Peña
Modified: 2013-03-11 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for 0.9.0 (4.58 KB, patch)
2013-03-05 16:35 UTC, Álvaro Peña 		reviewed Details | Review

Description Álvaro Peña 2013-03-04 12:04:35 UTC 
GApplication doesn't use "quit_mainloop" event since GIO 2.32[1], so Almanah doesn't encrypt the database[2] when the user close the application.

This bug affect to Almanah 0.9 and higher.

[1] http://developer.gnome.org/gio/stable/GApplication.htm see the "struct GApplicationClass" section.
[2] http://git.gnome.org/browse/almanah/commit/src/application.c?id=0d2374f0bd55461b8bb6ca3a234b60fb395c6f32 see "quit_main_loop" function
Comment 1 Álvaro Peña 2013-03-05 16:25:26 UTC 
Some affected distributions (Almanah >= 0.9.0 and GLib > 2.32):

Debian: Testing, Unstable and Experimental
Ubuntu: Quantal and Raring
Fedora: 18
Arch Linux.
Comment 2 Álvaro Peña 2013-03-05 16:35:54 UTC 
Created attachment 238141 [details] [review]
Patch for 0.9.0

This is a patch for a 0.9.1 release using the 0_9_0 tag as a new branch.

The patch just replace the quit_mainloop for the window_removed event.
Comment 3 Philip Withnall 2013-03-05 23:21:39 UTC 
Review of attachment 238141 [details] [review]:

Looks good to me.
Comment 4 Álvaro Peña 2013-03-11 10:18:39 UTC 
I'm going to make two new releases 0.9.1 (used in Debian testing) and 0.10.1 for the other cases right now.
Comment 5 Álvaro Peña 2013-03-11 11:26:31 UTC 
Releases already done and commited the patch to master branch.