GNOME Bugzilla – Bug 694989
"Analog Output" in volume OSD
Last modified: 2013-04-29 17:02:36 UTC
Created attachment 237788 [details] screenshot On my x220 laptop I get "Analog Output" in the volume OSD.
port->port = "analog-output" form-factor = "internal"
Created attachment 237799 [details] [review] media-keys: don't show label for analog-output ports
CC:ed David on this so he can give his opinion. I'm afraid this patch might cause headphones to not have a label in some cases.
I think the patch is OK. I don't know what the rules are for what should be shown or not; but if the intention is to hide everything that's labelled "Analog Output", then the patch is correct. If you plug the headphones in on an X220 and then try to set the volume, it will still show "Analog Output"...I think? I can't find any alsa-info of it right now, so not sure. Anyway, if you add "options snd-hda-intel model=auto" to a modprobe conf file (in Ubuntu, that would be /etc/modprobe.d/alsa-base.conf, don't know if Fedora works the same) and reboot, chances are you would get analog-output-speaker and analog-headphones just like most of the other computers. If you do this, find that it works, and attach your alsa-info, I'll send a patch upstream for making this the default in future kernels. Thanks!
(In reply to comment #4) > I think the patch is OK. I don't know what the rules are for what should be > shown or not; but if the intention is to hide everything that's labelled > "Analog Output", then the patch is correct. We want to hide the label for built-in speaker outputs. I was wondering whether there's a chance of a false positive here and have a headphones output with a hidden label instead.
In the X220 (and other) cases where there are just one analog-output, instead of analog-output-headphones and analog-output-speaker, "Analog Output" will be the active port regardless of whether headphones are plugged in or not.
Review of attachment 237799 [details] [review]: As per David's comment, looks fine to commit though you'll need to get the driver fixed to see the headphones label.
David, I can confirm that adding "options snd-hda-intel model=auto" makes the jack detection work. Awesome!
Attachment 237799 [details] pushed as 20b7828 - media-keys: don't show label for analog-output ports
I suppose this should get pushed to 3.8 too. David, has this fix been submitted to the upstream kernel yet?
@William, no, you never submitted any alsa-info (see http://git.alsa-project.org/?p=alsa-driver.git;a=blob_plain;f=alsa/utils/alsa-info.sh;hb=refs/heads/build ). I need alsa-info information in order to write a patch.
(In reply to comment #10) > I suppose this should get pushed to 3.8 too. Adapted to gnome-3-8.
http://www.alsa-project.org/db/?f=67646be2f51f839af0fc21ccb92d6f6a4878aa97
@William, upstreamed now: http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=a555bb8c6bf6932c5706745bfdbad22df26324d9
Yay. Thanks!