After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694924 - Dead code in GtkClipboard
Dead code in GtkClipboard
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-03-01 11:06 UTC by Aleksander Morgado
Modified: 2013-03-05 01:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for the issue. (1.77 KB, patch)
2013-03-01 11:07 UTC, Aleksander Morgado 		none Details | Review

Description Aleksander Morgado 2013-03-01 11:06:27 UTC 
In gtk_clipboard_set_contents(), once we have called clipboard_unset(), clipboard->get_func will always be NULL.

Patch following to remove the dead code.
Comment 1 Aleksander Morgado 2013-03-01 11:07:19 UTC 
Created attachment 237696 [details] [review]
Patch for the issue.
Comment 2 Matthias Clasen 2013-03-01 17:58:41 UTC 
Looks like you are right - the code is dead today. It would be good to check where it originated in git history, and when it died.
Comment 3 Aleksander Morgado 2013-03-02 11:40:14 UTC 
(In reply to comment #2)
> Looks like you are right - the code is dead today. It would be good to check
> where it originated in git history, and when it died.

According to git blame it was all introduced in commit 39339f14, when GtkClipboard was created; and it does seem the dead code was there already in that commit.
Comment 4 Matthias Clasen 2013-03-05 00:36:59 UTC 
ok then