Bug 694801 – fullscreen applications cannot be rendererd (they disappear as soon as they get focus)

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 694801 - fullscreen applications cannot be rendererd (they disappear as soon as they get focus)


Summary:	fullscreen applications cannot be rendererd (they disappear as soon as they g...


Status:	RESOLVED FIXED

Product:	mutter
Classification:	Core
Component:	general
Version:	3.7.x
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	---
Assigned To:	mutter-maint
QA Contact:	mutter-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2013-02-27 16:42 UTC by Alban Browaeys
Modified:	2013-02-27 17:01 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
metaWindow get_all_monitors takes a mandatory parameter (1014 bytes, patch) 2013-02-27 16:42 UTC, Alban Browaeys	rejected	Details \| Review
MetaWindow: fix annotation (1.01 KB, patch) 2013-02-27 16:51 UTC, Giovanni Campagna	committed	Details \| Review

Description Alban Browaeys 2013-02-27 16:42:16 UTC

Created attachment 237535 [details] [review]
metaWindow get_all_monitors takes a mandatory parameter

metaWindow get_all_monitors takes a mandatory parameter which is missing in js/ui/layout.js (this parameter can be null). Gnome shell error out with:
    JS ERROR: !!!   Exception was: Error: Unsupported type guint64 for (out caller-allocates)
    JS ERROR: !!!     message = '"Unsupported type guint64 for (out caller-allocates)"'
    JS ERROR: !!!     fileName = '"/opt/gnome/share/gnome-shell/js/ui/layout.js"'
    JS ERROR: !!!     lineNumber = '889'
    JS ERROR: !!!     stack = '"()@/opt/gnome/share/gnome-shell/js/ui/layout.js:889
wrapper()@/opt/gnome/share/gjs-1.0/lang.js:213
([object GObject_Object])@/opt/gnome/share/gnome-shell/js/ui/layout.js:905
wrapper([object GObject_Object])@/opt/gnome/share/gjs-1.0/lang.js:213

Fixes commit a361180745f6e135ebba0b4c7551bab2551dc834 .

Comment 1 Giovanni Campagna 2013-02-27 16:46:51 UTC

Review of attachment 237535 [details] [review]:

Sorry, but this patch is wrong. That argument is the length of the returned array.

The actual problem is the (caller-allocates) annotation, which is wrong (it makes sense for structures only), and should be removed.

Comment 2 Giovanni Campagna 2013-02-27 16:51:32 UTC

Created attachment 237538 [details] [review]
MetaWindow: fix annotation

caller-allocates makes sense only for structure, and gjs will complain
if used on anything else

Comment 3 Giovanni Campagna 2013-02-27 16:52:16 UTC

Please test, I'm currently a few revisions behind on the updates...

Comment 4 Florian Müllner 2013-02-27 16:59:02 UTC

Review of attachment 237538 [details] [review]:

Ha! Attaching untested patches is cheating ;-)

I was about to attach the same (tested!) patch, so go head ...

Comment 5 Giovanni Campagna 2013-02-27 17:01:07 UTC

Attachment 237538 [details] pushed as e6d5e98 - MetaWindow: fix annotation