After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694494 - Make use of posix_openpt() to open a pseudo-terminal device
Make use of posix_openpt() to open a pseudo-terminal device
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.34.x
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-23 02:53 UTC by Brad Smith
Modified: 2013-02-23 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make use of posix_openpt() (1003 bytes, patch)
2013-02-23 02:53 UTC, Brad Smith 		accepted-commit_now Details | Review
Make use of posix_openpt() (1009 bytes, patch)
2013-02-23 21:49 UTC, Brad Smith 		none Details | Review

Description Brad Smith 2013-02-23 02:53:40 UTC 
Created attachment 237228 [details] [review]
Make use of posix_openpt()

The attached patch modifies the VTE PTY code to make use of posix_openpt() to open a pseudo-terminal device. This is supported by POSIX.1-2001 compliant Operating Systems and some OS's like OpenBSD do not have the /dev/ptmx device so this is the only proper way of accessing a pseudo-terminal.
Comment 1 Christian Persch 2013-02-23 11:09:29 UTC 
Review of attachment 237228 [details] [review]:

With that fixed, ok to commit to vte-0-34 branch.

::: src/pty.c
@@ +813,3 @@
 {
 	int fd, flags, rv;
+#ifdef HAVE_POSIX_OPENPT

#if defined(...)
Comment 2 Brad Smith 2013-02-23 16:27:05 UTC 
Can you clarify your comment? The diff modifies the code as it should be already.
Comment 3 Christian Persch 2013-02-23 17:45:18 UTC 
You're using #ifdef ... #elif defined(...); that should be #if defined(...) ... #elif defined(...) instead.
Comment 4 Brad Smith 2013-02-23 21:49:46 UTC 
Created attachment 237258 [details] [review]
Make use of posix_openpt()
Comment 5 Brad Smith 2013-02-23 21:51:58 UTC 
Here is an updated diff. I only did so in that manner as code elsewhere within the same file uses #ifdef .. #elif defined(..) #else.
Comment 6 Christian Persch 2013-02-23 21:57:34 UTC 
Fixed on 0-34 and next.