After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694482 - missing a desktop file for the previewer
missing a desktop file for the previewer
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
3.8?
Depends on:
Blocks:
 
 
Reported: 2013-02-22 20:24 UTC by William Jon McCann
Modified: 2013-02-28 18:52 UTC
See Also:
GNOME target: 3.8
GNOME version: ---

Attachments
screenshot (74.02 KB, image/png)
2013-02-22 20:24 UTC, William Jon McCann 		  Details
Add desktop file for print preview (1.94 KB, patch)
2013-02-22 20:33 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-02-22 20:24:55 UTC 
Created attachment 237212 [details]
screenshot

The print previewer is missing a desktop file. This means that the application doesn't appear correctly in GNOME 3.
Comment 1 William Jon McCann 2013-02-22 20:33:36 UTC 
Created attachment 237214 [details] [review]
Add desktop file for print preview
Comment 2 Carlos Garcia Campos 2013-02-23 10:28:47 UTC 
Print previewer is not supposed to be an application, but a widget used by GTK+ print dialog to show the preview, that fact that this is implemented as an external application is an implementation detail.
Comment 3 William Jon McCann 2013-02-25 14:28:09 UTC 
The screenshot shows how broken it looks at the moment. Ideally it isn't an application. That is why it is NoDisplay=true. But in the case where it is used as a separate top level window it must have a desktop file.
Comment 4 Carlos Garcia Campos 2013-02-28 18:33:28 UTC 
Review of attachment 237214 [details] [review]:

I guess you also need to add the new file to po/POTFILES.in. This patch contains new translatable strings, so I guess you should ask for a break, please do it before pushing.
Comment 5 William Jon McCann 2013-02-28 18:48:39 UTC 
Attachment 237214 [details] pushed as 25024d4 - Add desktop file for print preview
Comment 6 William Jon McCann 2013-02-28 18:49:34 UTC 
Thanks. Fortunately, we're not in string freeze yet. Next Monday I believe.
Comment 7 Carlos Garcia Campos 2013-02-28 18:52:54 UTC 
Right, thanks!