Created attachment 237169 [details] [review]
ui: Don't use Clutter.Group

It is deprecated use Clutter.Actor instead.

Created attachment 237170 [details] [review]
windowManager: Don't use show_all

It is deprecated and does not make sense there anyway, so use show() instead.

Review of attachment 237169 [details] [review]:

Sure.

Review of attachment 237170 [details] [review]:

Go for it!

Review of attachment 237169 [details] [review]:

::: js/ui/layout.js
@@ +1088,3 @@
         this._corner._delegate = this;
 
+        this.actor.add_child(this._corner);

Oh, this reminds me - we are using add_actor() in tons of places, maybe we should quickly sed it everywhere?

Attachment 237169 [details] pushed as 627a241 - ui: Don't use Clutter.Group
Attachment 237170 [details] pushed as 9f3afdf - windowManager: Don't use show_all

(In reply to comment #5)
> Review of attachment 237169 [details] [review]:
> 
> ::: js/ui/layout.js
> @@ +1088,3 @@
>          this._corner._delegate = this;
> 
> +        this.actor.add_child(this._corner);
> 
> Oh, this reminds me - we are using add_actor() in tons of places, maybe we
> should quickly sed it everywhere?

No simple sed does not work ... for instance the app-picker disappears as well as the windows in alt-tab etc.

Some St widgets still use ClutterContainer overrides. In that case, add_child will not work.

I see two patches that have been pushed, so closing as fixed. Reopen if you want.