After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694415 - Don't require introspection.m4 to be installed system-wide
Don't require introspection.m4 to be installed system-wide
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-22 07:27 UTC by Evan Nemerson
Modified: 2013-02-25 23:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: don't require introspection.m4 to be installed system-wide (8.17 KB, patch)
2013-02-22 07:27 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2013-02-22 07:27:02 UTC
Created attachment 237144 [details] [review]
build: don't require introspection.m4 to be installed system-wide

There is currently a copy of introspection.m4, but it is in the top-level directory not AC_CONFIG_MACRO_DIR (i.e., m4/) and autogen.sh put does REQUIRED_M4MACROS=introspection.m4 which means introspection.m4 is required to be installed system-wide.

libgdata should either use the local copy of introspection.m4 or remove it.  A patch to do the former is attached.
Comment 1 Philip Withnall 2013-02-23 00:43:09 UTC
(In reply to comment #0)
> libgdata should either use the local copy of introspection.m4 or remove it.  A
> patch to do the former is attached.

Why? I think it’s reasonable to require that gobject-introspection be installed as a build-time requirement for libgdata. The alternative means I have to keep introspection.m4 up-to-date in the libgdata tree.

Is there some problem with requiring introspection.m4 to be installed system-wide which I’m missing?
Comment 2 Philip Withnall 2013-02-25 23:26:26 UTC
Review of attachment 237144 [details] [review]:

Sorry, I mis-parsed what you said. It all makes sense. Committed to master; thanks!

commit 560b0d59f5e5773a083de409f200e2392f8dcdc0
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Thu Feb 21 22:08:33 2013 -0800

    build: Don’t require introspection.m4 to be installed system-wide
    
    Keep and use a local copy, since libgdata only has g-i as an optional
    dependency.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=694415

 autogen.sh          |  1 -
 introspection.m4    | 94 ----------------------------------------------------------------------------------------------
 m4/introspection.m4 | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 94 insertions(+), 95 deletions(-)