GNOME Bugzilla – Bug 694374
alpha: improve descriptions of chroma keying-related properties and enums
Last modified: 2013-02-22 00:15:49 UTC
Attaching a série of patches that improve the clarity of the properties being exposed. Although this should benefit anybody who wants to use the alpha plugin, the improvements are quite noticeable when you look at the autogenerated UI shown in Pitivi, it makes it actually understandable for people who haven't read the source :)
Created attachment 237064 [details] [review] commit 1
Created attachment 237065 [details] [review] commit 2
Created attachment 237066 [details] [review] commit 3
Created attachment 237067 [details] [review] commit 4 This should settle the deal.
Created attachment 237104 [details] [review] alpha: Do not override the method with custom r/g/b values Cool! I'd suggest in the last commit to replace "The target red color value" by "The target red color value for custom RGB chroma" (same for green and blue) to make it clear that they are unused/irrelevant if the method is not set correctly. Note though that the custom r/g/b settings will override the method if set to green/blue (depending on the order they appear in in the g_object_set), so I'm attaching a patch (against master) that will not use the target-r/g/b values unless the method is set to custom.
Created attachment 237107 [details] [review] commit 4 v2 Revised commit as per Youness' suggestion.
Thanks for the patches! commit f5cb19e28762bfebeacbbae2159667ba45cb03dc Author: Jean-François Fortin Tam <nekohayo@gmail.com> Date: Thu Feb 21 11:15:23 2013 -0500 alpha: improve descriptions of chroma keying-related properties and enums https://bugzilla.gnome.org/show_bug.cgi?id=694374 commit a65fd146f8c42f7edb86d63d68a3e1a979d05c7e Author: Youness Alaoui <youness.alaoui@collabora.co.uk> Date: Thu Feb 21 15:01:15 2013 -0500 alpha: Do not override the method with custom r/g/b values Depending on the order g_object_set() calls aare made, the target r/g/b settings will override the method if set to green/blue. Change that so we do not use the target-r/g/b values unless the method is set to custom. https://bugzilla.gnome.org/show_bug.cgi?id=694374