GNOME Bugzilla – Bug 694362
[PATCH] Fix some deprecated declarations
Last modified: 2013-02-26 16:16:14 UTC
Created attachment 237042 [details] [review] Fix some deprecated declarations * gui_gtk.c: Fix deprecated declarations gtk_icon_info_free to g_object_unref and gtk_window_set_opacity -> gtk_widget_set_opacity using as GTK_WIDGET instead of GTK_WINDOW See https://mail.gnome.org/archives/commits-list/2013-February/msg02049.html * um-utils.c: Fix deprecated declarations gtk_icon_info_free to g_object_unref * scrollarea.c: Fix deprecated declarations gdk_window_get_pointer to gdk_window_get_device_position * cc-power-panel.c: Fix deprecated declarations gtk_scrolled_window_add_with_viewport to gtk_container_add http://www.mail-archive.com/crash-catcher@lists.fedorahosted.org/msg03480.html * cc-input-chooser.c: Fix maybe uninitialized warning with widget and initial var
Created attachment 237044 [details] Panel patches splitted as requested by irc Panel patches splitted as requested by irc
Comment on attachment 237044 [details] Panel patches splitted as requested by irc A tar.gz file isn't a "patch" in the bugzilla sense.
I didn't commit the patch about scrollarea.c as I'm not happy about the fact that the event is completely disconnected from the mouse pointer event itself. The rest is committed with the commit messages fixed.
what should be the proper fix for scrollarea.c then? It is the only way to remove gdk_window_get_pointer() that I know. If it is not fixed, we still get the deprecation warning at compilation time. For example, here are using the same trick: http://web.archiveorange.com/archive/v/bZBuSlfX3HWzorhZyMTo
(In reply to comment #4) > what should be the proper fix for scrollarea.c then? It is the only way to > remove gdk_window_get_pointer() that I know. The pointer position is supposed to come from a mouse event. > If it is not fixed, we still get > the deprecation warning at compilation time. Yes, but we have until GTK+ 4.0 to fix it.