Created attachment 236964 [details] [review]
endSessionDialog: don't process response until closed

oops forgot the preliminary patch

Created attachment 236967 [details] [review]
modalDialog: drop global.get_current_time() arguments to close

Modal dialogs take an optional timestamp in their close method.
If the timestamp is not passed in, then global.get_current_time()
is used.

Some callers of the close method pass in global.get_current_time()
unnecessarly (since it's the default).

This commit drops the argument for those cases.

Created attachment 236968 [details] [review]
modalDialog: emit 'closed' signal when dialog is closed

Opening and closing a modal dialog is not instant. There
is a transition animation involved.  When the dialog is
finished opening, it currently emits the "opened" signal.

When it's finished closing, however, it doesn't emit a
"closed" signal.  This means, there's not a good way to
know when the dialog finishes closing.

This commit adds the "closed" signal.

Created attachment 236969 [details] [review]
endSessionDialog: don't process response until closed

Right now if a user logs out, they are thrown to the login screen
imediately, without even seeing the dialog close.

This commit fades the dialog out before processing the logout.

(by preliminary i meant prerequisite)

Review of attachment 236967 [details] [review]:

OK.

Review of attachment 236968 [details] [review]:

OK.

Attachment 236967 [details] pushed as e9f18c6 - modalDialog: drop global.get_current_time() arguments to close
Attachment 236968 [details] pushed as 677cdfd - modalDialog: emit 'closed' signal when dialog is closed
Attachment 236969 [details] pushed as b4b13b0 - endSessionDialog: don't process response until closed