GNOME Bugzilla – Bug 694287
Fittsify scrollbars
Last modified: 2017-04-22 12:27:00 UTC
The scrollbars in the app view and search results run alongside the screen edge, but they can't actually be used when the pointer is touching that same edge. This makes them much more difficult to use. A combination of moving the scrollbar to the right and extending the area where they can be interacted with is probably in order.
The easy fix here is to move the scrollbar so that it touches the screen edge, but it would not look good probably. We can also add a right padding to StScrollBar, but it would extend the scroll view area, rather then the actual scrollbar, so the scrolling would be reversed (like it happens on the inside of the scroll view). Now, for the hard fix, we can add padding to StScrollBar, and move event handling there. Still, it would behave as if you clicked the through, not the handle, so if we want the full "ghost scrollbar" experience we need something more fancy and more complex, which I would be against, on technical grounds.
Created attachment 237008 [details] [review] theme: don't add horizontal padding to main scrolled views
Created attachment 237009 [details] [review] Revert "OverviewControl: simplify code to add bottom padding" This reverts commit a187111a261e305525b5a855ecdc7a8b7f89c529. We want views to extend to the bottom, and just adding padding to the overview won't work.
Created attachment 237010 [details] [review] theme: make scrollbars bigger in views
(In reply to comment #3) > Revert "OverviewControl: simplify code to add bottom padding" > > This reverts commit a187111a261e305525b5a855ecdc7a8b7f89c529. > > We want views to extend to the bottom, and just adding padding to the > overview won't work. I know I accepted this patch myself, but I changed my mind and I think this is worth reverting even if we don't accept the other theme patches, as it prevents search results from properly extending to the bottom.
Couldn't you add the padding to the dash and thumbnails (or possibly just the common container for the two) instead?
Sure that should work too. I just reverted that commit for this patch set as it was the quickest option.
Created attachment 237054 [details] [review] overviewControls: don't set padding on the whole overview group Set it on the control slider actor instead. At the same time, remove bottom padding from search results actor.
Created attachment 237055 [details] [review] theme: change the look of scrollbars in views - don't add padding on the side of scrolled views - make scrollbars larger in views
Review of attachment 237054 [details] [review]: Isn't there more than one sliding control? You need to use a style_class here if so.
Created attachment 237061 [details] [review] overviewControls: don't set padding on the whole overview group -- Now using a style class
Review of attachment 237061 [details] [review]: OK.
Comment on attachment 237061 [details] [review] overviewControls: don't set padding on the whole overview group Attachment 237061 [details] pushed as 656d24e - overviewControls: don't set padding on the whole overview group
What about the other patch here ?
Review of attachment 237055 [details] [review]: Personally I very much prefer the GTK+-like scrollbars we currently have, and I particularly dislike the scrollbars being visually attached to the monitor edge (but then I'm probably biased, as I use swipe scrolling / scroll wheel almost exclusively, so Fitts'ability is not much of an issue for me). Still, if the designers are OK with the visuals the patch is good to push with a freeze break exception.
ok, lets see if we can get some design review here.
Those scrollbars are gone now, closing as OBSOLETE.