After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694265 - Application view - use standard styling for frequent / all switcher
Application view - use standard styling for frequent / all switcher
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-20 13:31 UTC by Allan Day
Modified: 2013-02-20 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.17 KB, patch)
2013-02-20 13:36 UTC, Allan Day 		accepted-commit_now Details | Review
before and after screenshot (28.54 KB, image/png)
2013-02-20 13:42 UTC, Allan Day 		  Details
updated patch (3.30 KB, patch)
2013-02-20 16:25 UTC, Allan Day 		none Details | Review
appDisplay: Fix view-switcher buttons in RTL locales (966 bytes, patch)
2013-02-20 16:41 UTC, Florian Müllner 		committed Details | Review
theme: use standard button styling for the app view switcher (3.48 KB, patch)
2013-02-20 16:41 UTC, Florian Müllner 		committed Details | Review

Description Allan Day 2013-02-20 13:31:10 UTC 
The frequent/all switcher seems to use custom styling. We should probably use the standard button styling.
Comment 1 Allan Day 2013-02-20 13:36:08 UTC 
Created attachment 236928 [details] [review]
patch
Comment 2 Allan Day 2013-02-20 13:42:02 UTC 
Created attachment 236929 [details]
before and after screenshot

Master is on top, the patched version is on the bottom.
Comment 3 Florian Müllner 2013-02-20 13:52:56 UTC 
Review of attachment 236928 [details] [review]:

Patch looks good, feel free to push when you all agree on the looks (it definitively looks way better to me if that helps)
Comment 4 Allan Day 2013-02-20 16:25:58 UTC 
Created attachment 236948 [details] [review]
updated patch

This updated patch uses the standard radius too.
Comment 5 Florian Müllner 2013-02-20 16:41:10 UTC 
Created attachment 236954 [details] [review]
appDisplay: Fix view-switcher buttons in RTL locales
Comment 6 Florian Müllner 2013-02-20 16:41:26 UTC 
Created attachment 236955 [details] [review]
theme: use standard button styling for the app view switcher

Fix double-border in the center.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-02-20 16:42:14 UTC 
Review of attachment 236955 [details] [review]:

OK.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-02-20 16:42:20 UTC 
Review of attachment 236954 [details] [review]:

OK.
Comment 9 Florian Müllner 2013-02-20 16:47:40 UTC 
Attachment 236954 [details] pushed as fcded2e - appDisplay: Fix view-switcher buttons in RTL locales
Attachment 236955 [details] pushed as df3872f - theme: use standard button styling for the app view switcher