After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694254 - Validate desktop file during build
Validate desktop file during build
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-20 10:45 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Validate desktop file during build (1.26 KB, patch)
2013-02-20 10:45 UTC, Christophe Fergeau
committed Details | Review

Description Christophe Fergeau 2013-02-20 10:45:00 UTC
This is the second time that Boxes ship a tarball with an invalid
desktop file because of tranlation issues.
Better to run desktop-file-validate during build to detect such problems
early.
Comment 1 Christophe Fergeau 2013-02-20 10:45:02 UTC
Created attachment 236906 [details] [review]
Validate desktop file during build
Comment 2 Christophe Fergeau 2013-02-20 12:34:05 UTC
Another option is to remove the desktop-file-validate check from the fedora .spec
Comment 3 Zeeshan Ali 2013-02-20 14:02:52 UTC
Review of attachment 236906 [details] [review]:

Looks right, ack
Comment 4 Christophe Fergeau 2013-02-20 14:48:36 UTC
NB this would break the build so I won't commit that just know ;)
Comment 5 Christophe Fergeau 2013-02-22 09:11:22 UTC
Attachment 236906 [details] pushed as b06dc83 - Validate desktop file during build