After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694246 - gsttcp.c drop tcpconnection on EINTR
gsttcp.c drop tcpconnection on EINTR
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.36
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-20 07:24 UTC by Chris Ruehl
Modified: 2014-10-09 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
restart gst_poll_wait() when errno==EINTR (1.21 KB, patch)
2013-02-20 07:24 UTC, Chris Ruehl 		none Details | Review

Description Chris Ruehl 2013-02-20 07:24:20 UTC 
Created attachment 236901 [details] [review]
restart gst_poll_wait() when errno==EINTR

Hi, 
we are using the tcpclientsrc to connect a local loopback tcp port.
Its an embedded system armv7 - we discover a problem that the gsttcp.c :270
set the gst_poll_wait() and return with error if a Interupted System Call happen.
errno = EINTR.

At this point the EINTR is not to handle as an error. Its safe to retry setup the gst_poll_wait() again.

Please review attached patch which works great with our project!

regards
Chris
Comment 1 Sebastian Dröge (slomo) 2013-02-20 08:10:02 UTC 
This patch does not apply to GIT master (which was ported from plain sockets to GSocket). Could you update your patch (if it's still relevant) and also attach it in "git format-patch" format?
Comment 2 Chris Ruehl 2013-02-20 08:28:10 UTC 
I patched against the code in my OE (open embedded) build-root which using the
tar-archives loaded from the http://host/src/..

I must finish some work, and if done I will git-clone the master and provide you a patch ( if needed after the move to GSocket )

regards
Chris
Comment 3 Tim-Philipp Müller 2013-02-20 09:38:27 UTC 
Thanks Chris. Setting to NEEDINFO for update on if it still applies to git master, and new patch.
Comment 4 Tobias Mueller 2013-06-05 23:57:20 UTC 
Chris, ping
Comment 5 Chris Ruehl 2013-06-06 03:18:26 UTC 
Tobias,

pong. Sorry, very busy at the moment. But its important to us to know if the upstream has same problem. Please give me some time.

Chris Ruehl
Comment 6 Sebastian Dröge (slomo) 2014-10-08 08:15:47 UTC 
Ping?
Comment 7 Tim-Philipp Müller 2014-10-08 09:01:48 UTC 
Let's just close it for now.

Chris, please re-open or file a new bug if you find this still to be a problem with recent 1.x versions, thanks!
Comment 8 Nicolas Dufresne (ndufresne) 2014-10-09 15:07:45 UTC 
GIO GSocket deals with the EINTR errno in all cases and we use GSocket now, it seems to actually be obsolete.