After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694234 - AppPicker: scrolling is cut at the bottom
AppPicker: scrolling is cut at the bottom
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 694332 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-02-20 02:11 UTC by Cosimo Cecchi
Modified: 2013-02-21 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (343.03 KB, image/png)
2013-02-20 02:12 UTC, Cosimo Cecchi 		  Details
iconGrid: Take extra spacing into account for height requests (1.60 KB, patch)
2013-02-20 03:27 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-bin: fix a typo in the property setter (784 bytes, patch)
2013-02-20 04:06 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-02-20 02:11:41 UTC 
See attached screenshot
Comment 1 Cosimo Cecchi 2013-02-20 02:12:07 UTC 
Created attachment 236879 [details]
screenshot
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-20 02:14:31 UTC 
Right, the issue is that we add extra row spacing but don't ask for it in get_preferred_height. You could change this by separating row and column spacing in iconGrid.js and seeing how well that looks...
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-20 03:27:51 UTC 
Created attachment 236885 [details] [review]
iconGrid: Take extra spacing into account for height requests

This fixes the clipped app picker in the overview.


This still has issues if you try it in the shell now (where we have
a vertical fade), because of a Clutter bug. Fix for the Clutter bug
is at bug #694237.
Comment 4 Cosimo Cecchi 2013-02-20 04:06:33 UTC 
Created attachment 236886 [details] [review]
st-bin: fix a typo in the property setter

--

This might help as well.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-20 04:14:49 UTC 
Review of attachment 236886 [details] [review]:

Holy....
Comment 6 Cosimo Cecchi 2013-02-20 05:08:41 UTC 
Comment on attachment 236886 [details] [review]
st-bin: fix a typo in the property setter

Attachment 236886 [details] pushed as a4a5492 - st-bin: fix a typo in the property setter
Comment 7 Cosimo Cecchi 2013-02-20 05:16:07 UTC 
Review of attachment 236885 [details] [review]:

I had pretty much the same patch here - it's not enough without the clutter fix but it's correct.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-02-21 00:39:10 UTC 
Attachment 236885 [details] pushed as aad5d98 - iconGrid: Take extra spacing into account for height requests
Comment 9 drago01 2013-02-21 08:22:07 UTC 
*** Bug 694332 has been marked as a duplicate of this bug. ***
Comment 10 drago01 2013-02-21 08:25:59 UTC 
*** Bug 694327 has been marked as a duplicate of this bug. ***