After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694232 - gog_line_view_render: use of vals
gog_line_view_render: use of vals
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: Graphing / Charting
GIT
Other All
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-02-20 01:52 UTC by Morten Welinder
Modified: 2013-02-20 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2013-02-20 01:52:52 UTC 
What ensures that vals[i] as used on line 607 refers to a defined
value?
Comment 1 Morten Welinder 2013-02-20 01:55:08 UTC 
Ditto lengths[i] on 614?
Comment 2 Jean Bréfort 2013-02-20 07:20:24 UTC 
vals[i] and lengths[i] seems always initialized or I'm missing the obvious.

What's wrong on line 607 is that j might be larger than length[i]. Strange that this bug went unnoticed for 10 years (may be this plot type is not used a lot).
Comment 3 Morten Welinder 2013-02-20 13:28:15 UTC 
You're right, they are initialized.  At least if model->base.series is in
sync with model->num_series.  Let's assume that here.
Comment 4 Jean Bréfort 2013-02-20 15:41:42 UTC 
If they are not in sync, it's a bug num_series caches the series number. Fixed the use of extra values though.
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.