After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694215 - iconGrid: Dynamically adjust spacing based on columnLimit
iconGrid: Dynamically adjust spacing based on columnLimit
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 694192
 
 
Reported: 2013-02-19 21:56 UTC by drago01
Modified: 2013-02-19 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
iconGrid: Dynamically adjust spacing based on columnLimit (2.26 KB, patch)
2013-02-19 21:56 UTC, drago01 		none Details | Review
iconGrid: Dynamically adjust spacing based on columnLimit (2.87 KB, patch)
2013-02-19 22:41 UTC, drago01 		none Details | Review
iconGrid: Dynamically adjust spacing based on columnLimit (2.81 KB, patch)
2013-02-19 22:52 UTC, drago01 		accepted-commit_now Details | Review
iconGrid: Dynamically adjust spacing based on columnLimit (2.78 KB, patch)
2013-02-19 22:55 UTC, drago01 		none Details | Review
iconGrid: Dynamically adjust spacing based on columnLimit (2.83 KB, patch)
2013-02-19 22:58 UTC, drago01 		none Details | Review
iconGrid: Dynamically adjust spacing based on columnLimit (2.87 KB, patch)
2013-02-19 23:01 UTC, drago01 		committed Details | Review

Description drago01 2013-02-19 21:56:02 UTC 
Ths fixes the large screen issues introduced by the new app picker.
Comment 1 drago01 2013-02-19 21:56:04 UTC 
Created attachment 236844 [details] [review]
iconGrid: Dynamically adjust spacing based on columnLimit

Adjust the spacing based on the available width when a columnLimit
is set to evenly place the icons.
Comment 2 drago01 2013-02-19 22:41:14 UTC 
Created attachment 236846 [details] [review]
iconGrid: Dynamically adjust spacing based on columnLimit

Adjust the spacing based on the available width when a columnLimit
is set to evenly place the icons.

---

Updates based on IRC review.
Comment 3 drago01 2013-02-19 22:52:07 UTC 
Created attachment 236848 [details] [review]
iconGrid: Dynamically adjust spacing based on columnLimit

Adjust the spacing based on the available width when a columnLimit
is set to evenly place the icons.
Comment 4 drago01 2013-02-19 22:55:51 UTC 
Created attachment 236849 [details] [review]
iconGrid: Dynamically adjust spacing based on columnLimit

Adjust the spacing based on the available width when a columnLimit
is set to evenly place the icons.


Rebased.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-19 22:57:12 UTC 
Review of attachment 236848 [details] [review]:

Looks good.

::: js/ui/appDisplay.js
@@ +63,3 @@
         this._grid = new IconGrid.IconGrid({ xAlign: St.Align.MIDDLE,
                                              columnLimit: MAX_COLUMNS });
+        this._grid.actor.x_expand = true;

Adding a "// Standard hack for ClutterBinLayout" comment would be nice.
Comment 6 drago01 2013-02-19 22:58:27 UTC 
Created attachment 236850 [details] [review]
iconGrid: Dynamically adjust spacing based on columnLimit

Adjust the spacing based on the available width when a columnLimit
is set to evenly place the icons.


Readd lost "Math.round()"
Comment 7 drago01 2013-02-19 23:01:12 UTC 
Created attachment 236851 [details] [review]
iconGrid: Dynamically adjust spacing based on columnLimit

Adjust the spacing based on the available width when a columnLimit
is set to evenly place the icons.


OK, here is the one with the comment.
Waiting for the app-picker work to land first.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-02-19 23:08:36 UTC 
Review of attachment 236851 [details] [review]:

Looks good.
Comment 9 drago01 2013-02-19 23:39:34 UTC 
Attachment 236851 [details] pushed as b922035 - iconGrid: Dynamically adjust spacing based on columnLimit