After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694152 - compile errors in C++ due to G_BEGIN/END_DECLS
compile errors in C++ due to G_BEGIN/END_DECLS
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.8.x (obsolete)
Other Linux
: Normal blocker
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2013-02-19 10:15 UTC by Patrick Ohly
Modified: 2013-09-14 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add G_END_DECLS and G_BEGIN/END_DECLS pairs (3.02 KB, patch)
2013-02-19 10:16 UTC, Patrick Ohly 		none Details | Review
add missing boiler plate code (2.03 KB, patch)
2013-02-19 10:28 UTC, Patrick Ohly 		committed Details | Review

Description Patrick Ohly 2013-02-19 10:15:26 UTC 
Missing G_END_DECLS in e-book-types.h and camel-imapx-search.h cause
    compile errors in C++ code using EDS because the C++ code after the
    header files continues to be treated like C code.
    
    Some other headers in camel had no G_BEGIN/END_DECLS at all. Would
    have caused problems when trying to use the functions from C++.
Comment 1 Patrick Ohly 2013-02-19 10:16:03 UTC 
Created attachment 236733 [details] [review]
add G_END_DECLS and G_BEGIN/END_DECLS pairs
Comment 2 Patrick Ohly 2013-02-19 10:28:13 UTC 
Created attachment 236738 [details] [review]
add missing boiler plate code

Tristan already fixed the missing G_END_DECLS.
Comment 3 Milan Crha 2013-02-19 19:37:28 UTC 
Review of attachment 236738 [details] [review]:

Looks fine (the macros used to be out of the desc block usually). Feel free to commit. Thanks.
Comment 4 Milan Crha 2013-02-21 09:45:21 UTC 
Created commit b4b1f01 in eds master (3.7.91+)