GNOME Bugzilla – Bug 693781
Jumping settings dialog
Last modified: 2013-04-16 09:46:51 UTC
When I open the settings dialog for my wi-fi network, the dialog opens in an incorrect position (offset bottom-right from the main control center window) and then jumps to the correct location over the main window. Dialogs should open in the correct position and not jump around.
Created attachment 241430 [details] [review] network: Avoid jumping dialogs The connection editor window is shown before all of its pages are initialized, causing it to jump when it gets its final size. Avoid that by not showing it before it is ready.
Review of attachment 241430 [details] [review]: ::: panels/network/connection-editor/net-connection-editor.c @@ +938,3 @@ net_connection_editor_present (NetConnectionEditor *editor) { + g_idle_add ((GSourceFunc)present_cb, editor); We already have a g_idle_add() validating the pages' configurations (which I'd rather not have either). You could show the window in recheck_initialization() instead.
Created attachment 241561 [details] [review] network: Avoid jumping dialogs The connection editor window is shown before all of its pages are initialized, causing it to jump when it gets its final size. Avoid that by not showing it before it is ready.
I've removed the unnecessary changes in the idle callback. Thanks for the patch! Attachment 241561 [details] pushed as eb9c61f - network: Avoid jumping dialogs