After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693723 - Try to unlock keyring when storing
Try to unlock keyring when storing
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-13 16:13 UTC by Stef Walter
Modified: 2013-02-19 06:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Try to unlock locked collection when storing an item (6.24 KB, patch)
2013-02-13 16:34 UTC, Stef Walter 		none Details | Review
Try to unlock locked collection when storing an item (6.26 KB, patch)
2013-02-19 06:07 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2013-02-13 16:13:52 UTC 
If the keyring we're trying to store to is locked, currently libsecret fails to store the password. It should try to unlock the keyring.
Comment 1 Stef Walter 2013-02-13 16:34:06 UTC 
Created attachment 235907 [details] [review]
Try to unlock locked collection when storing an item

And add tests to verify this behavior.
Comment 2 Stef Walter 2013-02-18 14:20:20 UTC 
Jan, could you look this patch over? It's hard to find reviewers, so I usually ask those who point out bugs/requests features to help review the patch. Thanks in advance.
Comment 3 Jan Horak 2013-02-18 14:52:25 UTC 
Review of attachment 235907 [details] [review]:

It looks good to me. I've also successfully tested the patch with libsecret 0.13.

::: libsecret/secret-methods.c
@@ +1065,3 @@
+		secret_service_unlock_dbus_paths (service, paths, store->cancellable,
+		                                  on_store_unlock, g_object_ref (async));
+

aren't we leaking error here?
Comment 4 Stef Walter 2013-02-19 06:07:59 UTC 
Created attachment 236721 [details] [review]
Try to unlock locked collection when storing an item

And add tests to verify this behavior.
Comment 5 Stef Walter 2013-02-19 06:11:06 UTC 
Attachment 236721 [details] pushed as 0e9870b - Try to unlock locked collection when storing an item

Thanks. Added line to free the error, and pushed.