After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693397 - shell: Add additional arguments to bash completion file
shell: Add additional arguments to bash completion file
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-08 04:14 UTC by Jeremy Bicha
Modified: 2013-02-11 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Add additional arguments to bash completion file (1.16 KB, patch)
2013-02-08 04:14 UTC, Jeremy Bicha 		reviewed Details | Review
shell: Add additional arguments to bash completion file (1.40 KB, patch)
2013-02-09 03:46 UTC, Jeremy Bicha 		reviewed Details | Review
shell: Add additional arguments to bash completion file (1.41 KB, patch)
2013-02-11 16:33 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2013-02-08 04:14:09 UTC 
fix the FIXME
Comment 1 Jeremy Bicha 2013-02-08 04:14:10 UTC 
Created attachment 235479 [details] [review]
shell: Add additional arguments to bash completion file
Comment 2 Matthias Clasen 2013-02-09 02:41:44 UTC 
Review of attachment 235479 [details] [review]:

Nice, but it doesn't address the one panel that was called out in the fixme, network.
It supports create-wifi, connect-hidden-wifi, connect-8021x-wifi, connect-3g, show-device
Comment 3 Jeremy Bicha 2013-02-09 03:46:15 UTC 
Created attachment 235573 [details] [review]
shell: Add additional arguments to bash completion file
Comment 4 Matthias Clasen 2013-02-09 17:16:17 UTC 
Review of attachment 235573 [details] [review]:

you lost region and sound from your earlier patch
Comment 5 Jeremy Bicha 2013-02-09 20:40:56 UTC 
(In reply to comment #4)
> you lost region and sound from your earlier patch

I don't think I did…
Comment 6 Bastien Nocera 2013-02-11 09:39:50 UTC 
Review of attachment 235573 [details] [review]:

::: shell/completions/gnome-control-center.in
@@ +24,2 @@
 		for i in --overview --version @PANELS@; do
+			if [ keyboard = $prev ]; then

Using a switch() statement would be cleaner here.
Comment 7 Jeremy Bicha 2013-02-11 16:33:56 UTC 
Created attachment 235714 [details] [review]
shell: Add additional arguments to bash completion file
Comment 8 Bastien Nocera 2013-02-11 16:39:52 UTC 
Review of attachment 235714 [details] [review]:

Looks fine
Comment 9 Jeremy Bicha 2013-02-11 17:38:27 UTC 
Attachment 235714 [details] pushed as 2b830e0 - shell: Add additional arguments to bash completion file