After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693161 - Replace LoginManager:sessionActive with GnomeSession:SessionIsActive
Replace LoginManager:sessionActive with GnomeSession:SessionIsActive
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-04 21:03 UTC by Florian Müllner
Modified: 2013-02-08 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace LoginManager:sessionActive with GnomeSession:SessionIsActive (3.35 KB, patch)
2013-02-04 21:03 UTC, Florian Müllner 		committed Details | Review
loginManager: Remove sessionActive property (5.61 KB, patch)
2013-02-04 21:03 UTC, Florian Müllner 		committed Details | Review
autorunManager: Define this._session as an instance of GnomeSession (944 bytes, patch)
2013-02-08 16:26 UTC, Debarshi Ray 		needs-work Details | Review
autorunManager: Define this._session as an instance of GnomeSession (1.20 KB, patch)
2013-02-08 17:43 UTC, Debarshi Ray 		committed Details | Review

Description Florian Müllner 2013-02-04 21:03:01 UTC 
Kill some code by using the ConsoleKit/logind abstraction in gnome-session.
Comment 1 Florian Müllner 2013-02-04 21:03:06 UTC 
Created attachment 235164 [details] [review]
Replace LoginManager:sessionActive with GnomeSession:SessionIsActive

Gnome session started to track the session's active state a while
ago, so use that instead of our own ConsoleKit/logind abstraction
in LoginManager.
Comment 2 Florian Müllner 2013-02-04 21:03:10 UTC 
Created attachment 235165 [details] [review]
loginManager: Remove sessionActive property

It is unused after switching to GnomeSession:SessionIsActive, so
remove it together with shell_session_is_active_for_systemd().
Comment 3 Giovanni Campagna 2013-02-04 21:43:02 UTC 
Review of attachment 235164 [details] [review]:

Ok
Comment 4 Giovanni Campagna 2013-02-04 21:44:41 UTC 
Review of attachment 235165 [details] [review]:

Ok
Comment 5 Giovanni Campagna 2013-02-04 21:45:25 UTC 
(In reply to comment #3)
> Review of attachment 235164 [details] [review]:
> 
> Ok

On a second thought, you can remove the use of LoginManager altogether in those modules.
Comment 6 Florian Müllner 2013-02-04 23:02:52 UTC 
Attachment 235164 [details] pushed as 526a162 - Replace LoginManager:sessionActive with GnomeSession:SessionIsActive
Attachment 235165 [details] pushed as e0c5a61 - loginManager: Remove sessionActive property

(In reply to comment #5)
> On second thought, you can remove the use of LoginManager altogether in those
> modules.

Good catch, removed.
Comment 7 Debarshi Ray 2013-02-08 16:26:01 UTC 
Created attachment 235519 [details] [review]
autorunManager: Define this._session as an instance of GnomeSession
Comment 8 Florian Müllner 2013-02-08 16:28:31 UTC 
Review of attachment 235519 [details] [review]:

Eeeks. The patch is still wrong though, you'll also need to import misc.GnomeSession
Comment 9 Debarshi Ray 2013-02-08 17:43:28 UTC 
Created attachment 235529 [details] [review]
autorunManager: Define this._session as an instance of GnomeSession
Comment 10 Florian Müllner 2013-02-08 17:47:14 UTC 
Review of attachment 235529 [details] [review]:

LGTM