After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693140 - [API] codecparsers: h264: add profile enums
[API] codecparsers: h264: add profile enums
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-04 13:38 UTC by Gwenole Beauchesne
Modified: 2013-02-07 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
codecparsers: h264: add profile enums (2.08 KB, patch)
2013-02-04 13:38 UTC, Gwenole Beauchesne
accepted-commit_now Details | Review
codecparsers: h264: add profile enums (2.46 KB, patch)
2013-02-07 13:07 UTC, Gwenole Beauchesne
committed Details | Review

Description Gwenole Beauchesne 2013-02-04 13:38:16 UTC
Created attachment 235145 [details] [review]
codecparsers: h264: add profile enums

Hi, this patch adds some definitions for common H.264 profiles. I only enumerated the most common ones. I can also combine it with a patch to actually those in gsth264parser.c, if needed for sanity.
Comment 1 Tim-Philipp Müller 2013-02-04 22:57:25 UTC
Comment on attachment 235145 [details] [review]
codecparsers: h264: add profile enums

Go for it, but please also add a 'Since : 1.2' at the end of the gtk-doc chunk (or Since: 1.0.6 if you intend to pick it into 1.0 for some reason).
Comment 2 Gwenole Beauchesne 2013-02-07 13:07:21 UTC
Created attachment 235396 [details] [review]
codecparsers: h264: add profile enums

Hi, I will apply the following patch instead to git master. The only differences are the "Since: XXX" tag and a couple of more profiles for SVC, and the sake of completeness. :)
Comment 3 Gwenole Beauchesne 2013-02-07 17:40:36 UTC
commit 6e440f1da47c60581e91c43ad6cf247c848b9a3f
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Tue Oct 2 11:02:32 2012 +0200

    codecparsers: h264: add profile enums.
    
    Add all useful profiles from AVC, MVC and SVC specifications.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693140
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Comment 4 Tim-Philipp Müller 2013-02-07 17:46:39 UTC
1.1.1 is the next release leading up to 1.2.0, so that's what the target_milestone should be :)

1.2.x is for open bugs to indicate that they should ideally be fixed during the 1.2.x series.