GNOME Bugzilla – Bug 693018
File browser: don't use GIOScheduler (deprecated)
Last modified: 2019-03-23 20:56:47 UTC
The GIOScheduler API has been deprecated, and is used in the file browser plugin for sending files to the Trash location (or, if this operation is not possible, deleting the files, after confirmation by the user). The reason why the GIOScheduler API was used is because there was no async version of g_file_trash() and g_file_delete(). Now the async version of g_file_delete() is available, and I've sent a patch for the async version of g_file_trash(), see bug #548353. With the async versions, the implementation will normally be simpler.
The async version of g_file_trash() is now available.
Created attachment 241511 [details] [review] File browser: don't use GIOScheduler (deprecated) The GIOScheduler was used because there was no async version of g_file_delete() and g_file_trash(). Now that the async versions exist, no need to use GIOScheduler or GTask. gio >= 2.37.0 is required.
Review of attachment 241511 [details] [review]: Patch looks great, just push it after we branch after the next stable release. ::: plugins/filebrowser/gedit-file-browser-store.c @@ +3672,1 @@ model->priv->async_handles = g_slist_prepend (model->priv->async_handles, data); Just double check if this async_handles are still needed, or if something in the asyncdata can be removed.
Double checked, and pushed.