Created attachment 234768 [details] [review]
shell: Fix search result activation on Return key press

Review of attachment 234768 [details] [review]:

::: shell/gnome-control-center.c
@@ -87,3 @@
   gchar *filter_string;
 
-  guint32 last_time;

I'd rather this happened in a separate patch.

@@ +682,3 @@
+        }
+
+      on_search_row_activated (GTK_TREE_VIEW (priv->search_view), NULL, NULL, shell);

I don't really understand this patch.
on_search_row_activated () is the callback for the activate signal, which should get called when we call: gtk_icon_view_item_activated().

The only thing I could see missing is the setting of the selection (which I probably broke when I fixed another keyboard navigation related bug).

Created attachment 234803 [details] [review]
shell: Remove unused variable

Created attachment 234804 [details] [review]
shell: Fix search result activation on Return key press

--
(In reply to comment #2)
> -  guint32 last_time;
>
> I'd rather this happened in a separate patch.

Fair enough.

> @@ +682,3 @@
> +        }
> +
> +      on_search_row_activated (GTK_TREE_VIEW (priv->search_view), NULL, NULL,
> shell);
>
> I don't really understand this patch.
> on_search_row_activated () is the callback for the activate signal, which
> should get called when we call: gtk_icon_view_item_activated().
>
> The only thing I could see missing is the setting of the selection (which I
> probably broke when I fixed another keyboard navigation related bug).

Yeah, done that now. I was trying to avoid
gtk_tree_view_row_activated() since it needs a column and in this case
we don't really have one. But we can cheat and just user the 1st one.

Review of attachment 234803 [details] [review]:

++

Review of attachment 234804 [details] [review]:

Can you explain the changes made in the commit message as well? Looks fine otherwise.

(In reply to comment #6)
> Can you explain the changes made in the commit message as well?

Sure, hope it's ok.

Attachment 234803 [details] pushed as 75944f3 - shell: Remove unused variable
Attachment 234804 [details] pushed as 5357cde - shell: Fix search result activation on Return key press