(In reply to comment #0)
> It should only show up when enabled through the a11y status icon, the universal
> access panel, ...

Should it? Why should it pop up if there's potentially nothing to type into?

Because there are some cases it cannot detect (non-GTK+ apps for starters), and that it shows that the setting took effect.
Or not. Just not popping it up would certainly make things easier for me :)

Created attachment 234940 [details] [review]
keyboard: Don't show the keyboard when enabled

(In reply to comment #0)
> It should only show up when enabled through the a11y status icon, the universal
> access panel, or the keyboard shortcut used to toggle it.
> 
> When gnome-shell stops popping up the keyboard on its own when the setting
> changes, we can make all the above use the "Show" method on
> org.gnome.Caribou.Keyboard.

We need to add Enable/Disable methods to the Caribou DBus interface then because flipping the setting and calling Show() would be racy since Show() needs to check if the setting is enabled to actually show the OSK.

(In reply to comment #2)
> Because there are some cases it cannot detect (non-GTK+ apps for starters), and
> that it shows that the setting took effect.
> Or not. Just not popping it up would certainly make things easier for me :)

What are you trying to do?

See the bugs this blocks, enabling OSK automatically when touch is used, disabling it when not.

Review of attachment 234940 [details] [review]:

::: js/ui/keyboard.js
@@ -188,3 @@
-            if (showKeyboard)
-                this._timestamp = global.display.get_current_time_roundtrip() + 1;
-            this._setupKeyboard(showKeyboard);

we still need to call _setupKeyboard(). I propose that we keep calling it but just remove its parameter.

Created attachment 236274 [details] [review]
keyboard: Don't show the keyboard when enabled

Review of attachment 236274 [details] [review]:

Looks good.

Attachment 236274 [details] pushed as 30e4dce - keyboard: Don't show the keyboard when enabled