After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692454 - viewSelector: clean up active search state code
viewSelector: clean up active search state code
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-24 15:00 UTC by Cosimo Cecchi
Modified: 2013-01-24 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
viewSelector: clean up active search state code (4.76 KB, patch)
2013-01-24 15:00 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-01-24 15:00:48 UTC 
Just a cleanup of some quite messy code.
Comment 1 Cosimo Cecchi 2013-01-24 15:00:50 UTC 
Created attachment 234309 [details] [review]
viewSelector: clean up active search state code

'active' isn't terribly clear about just what is active; also, make it
private, remove an useless extra object state we were saving, and
refactor some messy code.
Based on a patch by Tanner Doshier.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-24 16:34:58 UTC 
Review of attachment 234309 [details] [review]:

Much better.
Comment 3 Cosimo Cecchi 2013-01-24 17:04:34 UTC 
Attachment 234309 [details] pushed as 4bd071b - viewSelector: clean up active search state code