After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692416 - Fix leaked weak reference on monitors.
Fix leaked weak reference on monitors.
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: mtp backend
1.15.x
Other Linux
: Normal normal
: ---
Assigned To: Philip Langdale
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-23 19:58 UTC by Philip Langdale
Modified: 2013-01-24 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix bug (1.34 KB, patch)
2013-01-23 19:58 UTC, Philip Langdale 		accepted-commit_now Details | Review

Description Philip Langdale 2013-01-23 19:58:03 UTC 
Created attachment 234252 [details] [review]
Patch to fix bug

We use a weak reference to automatically clean up the monitor
hash table when monitors are finalized. However, we still need
to remember to remove the weak references when the backend is
itself finalized - otherwise the reference might be fired later
if a monitor happens to get finalized before the backend exits
completely.
Comment 1 Tomas Bzatek 2013-01-24 18:18:10 UTC 
Review of attachment 234252 [details] [review]:

Right, seems correct to me.